Merged
Conversation
Contributor
|
This seems to be entirely editorial in the schema? |
ilkedemir
approved these changes
Sep 8, 2025
Collaborator
Author
Yes indeed, I copy pasted the schema from core but then your comment made me realize we were missing something (see https://github.com/c2pa-org/specs-core/pull/1797). I re-submitted this with the actual latest schema now. |
adam-gol
reviewed
Sep 11, 2025
adam-gol
reviewed
Sep 11, 2025
adam-gol
reviewed
Sep 11, 2025
Contributor
adam-gol
left a comment
adam-gol
left a comment
There was a problem hiding this comment.
The filename should be softbinding-algorithm-entry.schema.json, not softbinding-algorithm-entry-schema.json
"entry dot schema dot json" not "entry dash schema dot json".
Changing the workflow to match the renamed schema file.
jcollomosse
approved these changes
Sep 17, 2025
Collaborator
Author
|
Reviewed during the Oct 1st WM TF meeting and approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the schema to reflect changes in the core spec schema.